Abstract: Shanghai’s Smoke-free Environment Regulation, the first law of its kind promulgated by the provincial people’s Congress in mainland China, was implemented in March, 2010. The consecutive years of sample monitoring data on the settings banned of smoking by the regulation showed that in comparison with the regulation implementation before, violation in statutory no smoking places has a significant decline, the positive effects of smoke-free legislation for the control of tobacco hazards presents. But at the same time the regulation has also encountered many difficulties and problems in the implementation process, the reason can be traced back to the hysteresis of the legal texts. The author’s central ideas are: the impact assessment of regulation provided the evidence base for the future; and the further enhancement of Shanghai tobacco effects could only seek a breakthrough from the design and amendment of the rules of law.